Merge #12693: Remove unused variable in SortForBlock
ClosedPublic
Actions

Authored by nakihito on Jul 29 2019, 19:38.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING2d00337ef740: Merge #12693: Remove unused variable in SortForBlock
rABC2d00337ef740: Merge #12693: Remove unused variable in SortForBlock

Summary

bb079a0e2c Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5

Backport of Core PR12693
https://github.com/bitcoin/bitcoin/pull/12693/

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 29 2019, 19:38

Owners added a reviewer: Restricted Owners Package.Jul 29 2019, 19:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2019, 19:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6993: Diff 10519.Jul 29 2019, 19:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Jul 29 2019, 19:52

This revision is now accepted and ready to land.Jul 29 2019, 19:52

Closed by commit rABC2d00337ef740: Merge #12693: Remove unused variable in SortForBlock (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJul 29 2019, 21:22

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC2d00337ef740: Merge #12693: Remove unused variable in SortForBlock.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING2d00337ef740: Merge #12693: Remove unused variable in SortForBlock.Sep 19 2019, 01:30

Revision Contents
Changeset List

Path

Size

src/

miner.h

1 line

miner.cpp

4 lines

Diff 10521

View Options

src/miner.h