Page MenuHomePhabricator

Merge #12780: Reduce variable scopes
ClosedPublic

Authored by jasonbcox on Jul 30 2019, 22:51.

Details

Summary

6a318e48a6 Reduce variable scopes (practicalswift)

Pull request description:

Reduce variable scopes.

Tree-SHA512: 5c7735344024cb6cd310e739886dc811a64b640a0d6aac8b3d04f49e5987d6ff6676d978890bc84f1460527d92217176a79b007f0bf6b4147c04abfec2c67714

Backport of Core PR12780
https://github.com/bitcoin/bitcoin/pull/12780/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Jul 30 2019, 22:51
Fabien requested changes to this revision.Jul 31 2019, 06:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/recentrequeststablemodel.cpp
137 ↗(On Diff #10533)

Remove

This revision now requires changes to proceed.Jul 31 2019, 06:52
jasonbcox updated this revision to Diff 10578.Aug 2 2019, 16:58

Rebase + fix

Fabien accepted this revision.Aug 2 2019, 18:02
This revision is now accepted and ready to land.Aug 2 2019, 18:02
This revision was automatically updated to reflect the committed changes.