Page MenuHomePhabricator
Differential D3774

Merge #12780: Reduce variable scopes
ClosedPublic
Actions

Authored by jasonbcox on Jul 30 2019, 22:51.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING48c25e9b7b42: Merge #12780: Reduce variable scopes
rABC48c25e9b7b42: Merge #12780: Reduce variable scopes
Summary

6a318e48a6 Reduce variable scopes (practicalswift)

Pull request description:

Reduce variable scopes.

Tree-SHA512: 5c7735344024cb6cd310e739886dc811a64b640a0d6aac8b3d04f49e5987d6ff6676d978890bc84f1460527d92217176a79b007f0bf6b4147c04abfec2c67714

Backport of Core PR12780
https://github.com/bitcoin/bitcoin/pull/12780/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12780
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7035
Build 12117: Bitcoin ABC Buildbot (legacy)
Build 12116: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 30 2019, 22:51
Herald added a reviewer: deadalnix. · View Herald TranscriptJul 30 2019, 22:51
teamcity added a comment.Jul 30 2019, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 30 2019, 22:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7005: Diff 10533.Jul 30 2019, 22:59
Fabien requested changes to this revision.Jul 31 2019, 06:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/recentrequeststablemodel.cpp
137 ↗(On Diff #10533)

Remove

This revision now requires changes to proceed.Jul 31 2019, 06:52
jasonbcox updated this revision to Diff 10578.Aug 2 2019, 16:58

Rebase + fix

teamcity added a comment.Aug 2 2019, 16:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 2 2019, 17:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7035: Diff 10578.Aug 2 2019, 17:04
Fabien accepted this revision.Aug 2 2019, 18:02
This revision is now accepted and ready to land.Aug 2 2019, 18:02
Closed by commit rABC48c25e9b7b42: Merge #12780: Reduce variable scopes (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyAug 5 2019, 16:29
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC48c25e9b7b42: Merge #12780: Reduce variable scopes.
jasonbcox added a commit: rSTAGING48c25e9b7b42: Merge #12780: Reduce variable scopes.Sep 19 2019, 01:37

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines
test/
2 lines
4 lines

Diff 10578

View Options

src/qt/recentrequeststablemodel.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...