Page MenuHomePhabricator

Be nice to peer that relay non replay protected transactions.

Authored by deadalnix on Jul 26 2017, 11:34.



Many peer will relay non replay protected transactions, so we want to be nice to them at least in the short term.

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Looks good to me.

1417 ↗(On Diff #941)

It would be nice to add some more rationale to this comment, like what is written in the summary. Without it, it's difficult to understand why this code is here.

And it would make more sense to me if this comment was moved to before check2 instantiational, or to right before if if() conditional. I prefer higher up though.

This revision is now accepted and ready to land.Jul 26 2017, 12:29

Agree an explanatory comment for the reason for the 2 checks is warranted. It's not obvious.

Make comment more explicit

This revision was automatically updated to reflect the committed changes.