Page MenuHomePhabricator

macOS: Prevent Xcode 9.3 build warnings

Authored by Fabien on Aug 1 2019, 20:36.


This PR solves #12867 (needs to run && ./configure)

clang (Apple LLVM version 9.1.0 (clang-902.0.39.1)) warns unused
argument '-pie' during compilation.
So we check for warnings in the test using $CXXFLAG_WERROR.

Windows is also default-pie and was special-cased because it also
warned, but we can also eliminate that case if warnings are caught.

Backport of core PR12899

Depends on D3792 (for the test plan).

Test Plan

Cross build for windows and OSX, with both autotools and cmake
Use contrib/devtools/ on the windows binaries to
check that PIE is still enforced, and use file on OSX binaries.

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.