Paths

Table of Contentst

Differential D3793

macOS: Prevent Xcode 9.3 build warnings
ClosedPublic
Actions

Authored by Fabien on Aug 1 2019, 20:36.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4f0e8a5a102a: macOS: Prevent Xcode 9.3 build warnings
rABC4f0e8a5a102a: macOS: Prevent Xcode 9.3 build warnings

Summary

This PR solves #12867 (needs to run autogen.sh && ./configure)

clang (Apple LLVM version 9.1.0 (clang-902.0.39.1)) warns unused
argument '-pie' during compilation.
So we check for warnings in the test using $CXXFLAG_WERROR.

Windows is also default-pie and was special-cased because it also
warned, but we can also eliminate that case if warnings are caught.

Backport of core PR12899
https://github.com/bitcoin/bitcoin/pull/12899/files

Depends on D3792 (for the test plan).

Test Plan

Cross build for windows and OSX, with both autotools and cmake
Use contrib/devtools/security-check.py on the windows binaries to
check that PIE is still enforced, and use file on OSX binaries.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 1 2019, 20:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 1 2019, 20:36

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7028: Diff 10567.Aug 1 2019, 20:43

deadalnix accepted this revision.Aug 5 2019, 05:40

This revision is now accepted and ready to land.Aug 5 2019, 05:40

Closed by commit rABC4f0e8a5a102a: macOS: Prevent Xcode 9.3 build warnings (authored by Akio Nakamura <nakamura@dgtechnologies.co.jp>, committed by Fabien). · Explain WhyAug 5 2019, 07:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4f0e8a5a102a: macOS: Prevent Xcode 9.3 build warnings.

jasonbcox added a reverting change: D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".Aug 11 2019, 21:50

jasonbcox added a reverting change: rABC29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings".Aug 12 2019, 14:51

Fabien added a commit: rSTAGING4f0e8a5a102a: macOS: Prevent Xcode 9.3 build warnings.Sep 19 2019, 01:36

jasonbcox added a reverting change: rSTAGING29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings".Sep 19 2019, 01:45

Revision Contents
Changeset List

Path

Size

6 lines

src/

8 lines

Diff 10600

configure.ac

Loading...

src/CMakeLists.txt

Loading...