Differential D3799

[CMAKE] Enable -Wthread-safety-analysis
ClosedPublic
Actions

Authored by Fabien on Aug 5 2019, 08:22.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING8f2f9c478a9e: [CMAKE] Enable -Wthread-safety-analysis
rABC8f2f9c478a9e: [CMAKE] Enable -Wthread-safety-analysis

Summary

This is already enabled with autotools.

Test Plan

With Clang:

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_enable_thread_safety_analysis

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7040
Build 12127: Bitcoin ABC Buildbot (legacy)
Build 12126: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 5 2019, 08:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2019, 08:22

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7040: Diff 10606.Aug 5 2019, 08:28

deadalnix accepted this revision.Aug 6 2019, 06:13

This revision is now accepted and ready to land.Aug 6 2019, 06:13

Closed by commit rABC8f2f9c478a9e: [CMAKE] Enable -Wthread-safety-analysis (authored by Fabien). · Explain WhyAug 6 2019, 09:03

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8f2f9c478a9e: [CMAKE] Enable -Wthread-safety-analysis.

Fabien mentioned this in D3786: [CMAKE] Make warnings the same with cmake and autotools.Aug 6 2019, 09:20

Fabien added a commit: rSTAGING8f2f9c478a9e: [CMAKE] Enable -Wthread-safety-analysis.Sep 19 2019, 01:39

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

3 lines

Diff 10606

View Options

[CMAKE] Enable -Wthread-safety-analysisClosedPublicActions