Page MenuHomePhabricator

Add -ftrapv to DEBUG_CXXFLAGS when --enable-debug is used
ClosedPublic

Authored by Fabien on Aug 5 2019, 16:11.

Details

Summary
By generating a trap for signed overflow on addition, subtraction,
multiplication operations in the Travis testing we are more likely to
identify problematic code prior to merging it.

Backport of core PR12686
https://github.com/bitcoin/bitcoin/pull/12686/files

Test Plan
mkdir build && cd build
../configure --enable-debug
make check

mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja check

./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12686
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7045
Build 12137: Bitcoin ABC Buildbot (legacy)
Build 12136: arc lint + arc unit