Page MenuHomePhabricator

Merge #12128: Refactor: One CBaseChainParams should be enough
ClosedPublic

Authored by nakihito on Mon, Aug 5, 21:36.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC784be9ae126b: Merge #12128: Refactor: One CBaseChainParams should be enough
Summary

1687cb4 Refactor: One CBaseChainParams should be enough (Jorge Timón)

Pull request description:

There's no need for class hierarchy with CBaseChainParams, it is just a struct with 2 fields.
This starts as a +10-43 diff

Tree-SHA512: 0a7dd64ab785416550b541787c6083540e4962d76b6cffa806bb3593aec2daf1752dfe65ac5cd51b34ad5c31dd8292c422b483fdd2d37d0b7e68725498ed4c2d

Backport of Core PR12128
https://github.com/bitcoin/bitcoin/pull/12128/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Mon, Aug 5, 21:36
Owners added a reviewer: Restricted Owners Package.Mon, Aug 5, 21:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Aug 5, 21:36
jasonbcox accepted this revision.Mon, Aug 5, 21:41
This revision is now accepted and ready to land.Mon, Aug 5, 21:41