Merge #12128: Refactor: One CBaseChainParams should be enough
ClosedPublic
Actions

Authored by nakihito on Aug 5 2019, 21:36.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING784be9ae126b: Merge #12128: Refactor: One CBaseChainParams should be enough
rABC784be9ae126b: Merge #12128: Refactor: One CBaseChainParams should be enough

Summary

1687cb4 Refactor: One CBaseChainParams should be enough (Jorge Timón)

Pull request description:

There's no need for class hierarchy with CBaseChainParams, it is just a struct with 2 fields.
This starts as a +10-43 diff

Tree-SHA512: 0a7dd64ab785416550b541787c6083540e4962d76b6cffa806bb3593aec2daf1752dfe65ac5cd51b34ad5c31dd8292c422b483fdd2d37d0b7e68725498ed4c2d

Backport of Core PR12128
https://github.com/bitcoin/bitcoin/pull/12128/

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12128

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7047
Build 12141: Bitcoin ABC Buildbot (legacy)
Build 12140: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 5 2019, 21:36

Owners added a reviewer: Restricted Owners Package.Aug 5 2019, 21:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2019, 21:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Aug 5 2019, 21:41

This revision is now accepted and ready to land.Aug 5 2019, 21:41

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7047: Diff 10618.Aug 5 2019, 21:46

Closed by commit rABC784be9ae126b: Merge #12128: Refactor: One CBaseChainParams should be enough (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 6 2019, 03:17

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC784be9ae126b: Merge #12128: Refactor: One CBaseChainParams should be enough.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING784be9ae126b: Merge #12128: Refactor: One CBaseChainParams should be enough.Sep 19 2019, 01:38

Revision Contents
Changeset List

Path

Size

src/

chainparamsbase.h

6 lines

chainparamsbase.cpp

36 lines

Diff 10618

View Options

src/chainparamsbase.h