Page MenuHomePhabricator

[SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter
ClosedPublic

Authored by Fabien on Aug 9 2019, 10:46.

Details

Summary

javax.xml.bind.DatatypeConverter is no longer part of the Java JDK
since version 9. This make it impossible to build and run the JNI test
suite with any Java > 8.
This diff replaces the 2 functions from DatatypeConverter with some
very simple ones. Performance is not really an issue here as it is test
only code.

Depends on D3834.

Test Plan
./contrib/teamcity/build-secp256k1.sh # Tested with Java 8 and Java 11

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Aug 9 2019, 10:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2019, 10:46
Fabien edited the test plan for this revision. (Show Details)Aug 9 2019, 10:49
jasonbcox requested changes to this revision.Aug 9 2019, 16:09
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/java/org/bitcoin/NativeSecp256k1Test.java
11 ↗(On Diff #10696)

assert(len % 2 != 0)

This revision now requires changes to proceed.Aug 9 2019, 16:09
Fabien updated this revision to Diff 10726.Aug 12 2019, 13:11

Assert that the hex string length is even.

jasonbcox accepted this revision.Aug 16 2019, 00:49
This revision is now accepted and ready to land.Aug 16 2019, 00:49