Page MenuHomePhabricator
Differential D3835

[SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter
ClosedPublic
Actions

Authored by Fabien on Aug 9 2019, 10:46.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa6371c4a479b: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter
rABCa6371c4a479b: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter
Summary

javax.xml.bind.DatatypeConverter is no longer part of the Java JDK
since version 9. This make it impossible to build and run the JNI test
suite with any Java > 8.
This diff replaces the 2 functions from DatatypeConverter with some
very simple ones. Performance is not really an issue here as it is test
only code.

Depends on D3834.

Test Plan
./contrib/teamcity/build-secp256k1.sh # Tested with Java 8 and Java 11

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 9 2019, 10:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2019, 10:46
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 9 2019, 10:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien edited the test plan for this revision. (Show Details)Aug 9 2019, 10:49
teamcity added a comment.Aug 9 2019, 10:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7094: Diff 10696.Aug 9 2019, 10:52
jasonbcox requested changes to this revision.Aug 9 2019, 16:09
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/java/org/bitcoin/NativeSecp256k1Test.java
11 ↗(On Diff #10696)

assert(len % 2 != 0)

This revision now requires changes to proceed.Aug 9 2019, 16:09
Fabien updated this revision to Diff 10726.Aug 12 2019, 13:11

Assert that the hex string length is even.

teamcity added a comment.Aug 12 2019, 13:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 12 2019, 13:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7115: Diff 10726.Aug 12 2019, 13:18
Fabien mentioned this in D3834: [TRIVIAL] Cleanup the JNI test file.Aug 13 2019, 06:48
jasonbcox accepted this revision.Aug 16 2019, 00:49
This revision is now accepted and ready to land.Aug 16 2019, 00:49
Closed by commit rABCa6371c4a479b: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter (authored by Fabien). · Explain WhySep 9 2019, 12:33
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa6371c4a479b: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.
Fabien added a commit: rSTAGINGa6371c4a479b: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.Sep 19 2019, 02:12

Revision Contents
Changeset List

PathSize
src/
secp256k1/
2 lines
src/
java/
org/
bitcoin/
100 lines

Diff 11159

View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/src/java/org/bitcoin/NativeSecp256k1Test.java

Loading...