Differential D3844

Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning
ClosedPublic
Actions

Authored by nakihito on Aug 9 2019, 20:57.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING61b72926bc84: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of…
rABC61b72926bc84: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of…

Summary

0000d8f Document how FlushStateMode::NONE is handled (practicalswift)
2311c7c Call FlushStateToDisk(...) regardless of fCheckForPruning (practicalswift)

Pull request description:

FlushStateToDisk(...) won't do anything besides check if we need to prune if
FLUSH_STATE_NONE is given. We avoid reading the variable fCheckForPruning
which is guarded by the mutex cs_LastBlockFile.

Tree-SHA512: 89df06256f73503a74b9e26d580ce9ed09efaef347fae1ff6a5759a2993b0db52edd2fadb65694d27e579a5aed92127753bdf41b5bb1bd516e577fcf17f17999

Backport of Core PR11617
https://github.com/bitcoin/bitcoin/pull/11617/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 9 2019, 20:57

Owners added a reviewer: Restricted Owners Package.Aug 9 2019, 20:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2019, 20:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7103: Diff 10707.Aug 9 2019, 21:03

deadalnix accepted this revision.Aug 12 2019, 05:32

This revision is now accepted and ready to land.Aug 12 2019, 05:32

Closed by commit rABC61b72926bc84: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 12 2019, 17:36

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC61b72926bc84: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of….

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING61b72926bc84: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of….Sep 19 2019, 01:46

Revision Contents
Changeset List

Path

Size

src/

8 lines

Diff 10733

src/validation.cpp

Loading...