Page MenuHomePhabricator

Merge #11422: qa: Verify DBWrapper iterators are taking snapshots
ClosedPublic

Authored by nakihito on Mon, Aug 12, 20:28.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCe8913989601e: Merge #11422: qa: Verify DBWrapper iterators are taking snapshots
Summary

bb8376b Verify DBWrapper iterators are taking snapshots (Matt Corallo)

Pull request description:

The LevelDB docs seem to indicate that an iterator will not take
snapshots (even providing instructions on how to do so yourself).
In several of the places we use them, we assume snapshots to have
been taken.

In order to make sure LevelDB doesn't change out from under us
(and to prevent the next person who reads the docs from having the
same fright I did), verify that snapshots are taken in our tests.

Tree-SHA512: 54f24dabc294962e9c20882f61809604421a661208d1568bb107102248603e8e7c12e929ccb0812a73d4e4f23fea61f1b48e7cc24da5a7260f1d14d89ba88cd6

Backport of Core PR11422
https://github.com/bitcoin/bitcoin/pull/11422/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Mon, Aug 12, 20:28
Owners added a reviewer: Restricted Owners Package.Mon, Aug 12, 20:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Aug 12, 20:28
jasonbcox requested changes to this revision.Tue, Aug 13, 01:21
jasonbcox added inline comments.
src/test/dbwrapper_tests.cpp
210 ↗(On Diff #10737)

brackets

220 ↗(On Diff #10737)

brackets

This revision now requires changes to proceed.Tue, Aug 13, 01:21
nakihito updated this revision to Diff 10754.Tue, Aug 13, 02:03

Added brackets.

Fabien accepted this revision.Tue, Aug 13, 07:54
jasonbcox accepted this revision.Tue, Aug 13, 23:39
This revision is now accepted and ready to land.Tue, Aug 13, 23:39