Page MenuHomePhabricator

Merge #11422: qa: Verify DBWrapper iterators are taking snapshots
ClosedPublic

Authored by nakihito on Aug 12 2019, 20:28.

Details

Summary

bb8376b Verify DBWrapper iterators are taking snapshots (Matt Corallo)

Pull request description:

The LevelDB docs seem to indicate that an iterator will not take
snapshots (even providing instructions on how to do so yourself).
In several of the places we use them, we assume snapshots to have
been taken.

In order to make sure LevelDB doesn't change out from under us
(and to prevent the next person who reads the docs from having the
same fright I did), verify that snapshots are taken in our tests.

Tree-SHA512: 54f24dabc294962e9c20882f61809604421a661208d1568bb107102248603e8e7c12e929ccb0812a73d4e4f23fea61f1b48e7cc24da5a7260f1d14d89ba88cd6

Backport of Core PR11422
https://github.com/bitcoin/bitcoin/pull/11422/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 12 2019, 20:28
jasonbcox requested changes to this revision.Aug 13 2019, 01:21
jasonbcox added inline comments.
src/test/dbwrapper_tests.cpp
210 ↗(On Diff #10737)

brackets

220 ↗(On Diff #10737)

brackets

This revision now requires changes to proceed.Aug 13 2019, 01:21
This revision is now accepted and ready to land.Aug 13 2019, 23:39