Allows implementing different strategies for calculating the maximum block size limit.
BIP101 block size policy
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project
This is WIP. The BIP101 code is untested. This diff is for presenting the concept of multiple block size policies and requesting feedback.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ec
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 601 Build 601: arc lint + arc unit
Event Timeline
| src/blockencodings.cpp | ||
|---|---|---|
| 57 | BU uses the vocable "Excessive block size" . I think we should use the same. | |
| src/config.h | ||
| 16 | I'm not sure why this should be a policy itself. | |
| src/init.cpp | ||
| 1412 | bip100 will have to go in another diff. | |
| src/policy/blocksizepolicy.h | ||
| 23 | This isn't a very good API overall. See https://pragprog.com/articles/tell-dont-ask This class should also be non copyable. Maybe prefix with an I to explicit this is actually an interface. | |
| src/test/config_tests.cpp | ||
| 16 | You mark this static instead of using an anonymous namespace (the semantic is the same). | |
| 25 | It's unclear what's throwing here. Just have a test for the construction of StaticBlockSize . | |
Comment Actions
This I think is missing the key feature we want: being able to reconsider a block that goes over the limit when some condition is reached.
| src/blockencodings.cpp | ||
|---|---|---|
| 57 | This is not the same as Excessive block size. For example BU has AD, where blocks exceed excessive block size. BU nodes still have DoS limit though, which if I remember correctly is EB * 10. | |
| src/config.h | ||
| 16 | Because, currently, it wraps the API anyway. Inheriting the interface has two upsides:
| |
| src/init.cpp | ||
| 1412 | Agree. I wanted it in this WIP as a proof of concept for review. | |