Page MenuHomePhabricator
Differential D3872

make CheckMinimalPush available to codebase
ClosedPublic
Actions

Authored by markblundeberg on Aug 14 2019, 14:43.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa9957345dd26: make CheckMinimalPush available to codebase
rABCa9957345dd26: make CheckMinimalPush available to codebase
Summary

Besides the script evaluator, it can be useful in other script parsers to
find out whether a given push was minimal or not.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkminimal
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7143
Build 12331: Bitcoin ABC Buildbot (legacy)
Build 12330: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Aug 14 2019, 14:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2019, 14:43
teamcity added a comment.Aug 14 2019, 14:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D3865: recognize bare multisigs as standard only when using minimal pushes.Aug 14 2019, 14:49
teamcity added a comment.Aug 14 2019, 14:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7143: Diff 10782.Aug 14 2019, 14:54
jasonbcox accepted this revision.Aug 14 2019, 16:24
This revision is now accepted and ready to land.Aug 14 2019, 16:24
Closed by commit rABCa9957345dd26: make CheckMinimalPush available to codebase (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyAug 14 2019, 21:11
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCa9957345dd26: make CheckMinimalPush available to codebase.
markblundeberg added a child revision: D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.Aug 14 2019, 23:10
markblundeberg removed a child revision: D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGa9957345dd26: make CheckMinimalPush available to codebase.Sep 19 2019, 01:50

Revision Contents
Changeset List

PathSize
src/
script/
31 lines
6 lines
31 lines

Diff 10782

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script.h

Loading...
View Options

src/script/script.cpp

Loading...