Page MenuHomePhabricator

Merge #12747: Fix typos
ClosedPublic

Authored by nakihito on Aug 16 2019, 19:42.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8cd5e4ccde0c: Merge #12747: Fix typos
rABC8cd5e4ccde0c: Merge #12747: Fix typos
Summary

d27327c79a Fix typos (practicalswift)

Pull request description:

Fix typos.

Tree-SHA512: f0d13d991acdec0d3adc2f091cd00ccbdda6da3c7623dfb4cbf698bac9eb6b3d88c8ad121256a96cb130f8e97bf54892f3616da0e8dc833dcf713ca7949e2801

Backport of Core PR12747
https://github.com/bitcoin/bitcoin/pull/12747/

Test Plan
make check
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12747
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7174
Build 12393: Bitcoin ABC Buildbot (legacy)
Build 12392: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 16 2019, 19:42

The misspelled variable and function names were already correct.
See: D3306, D3243, and D3180

Fabien requested changes to this revision.Aug 26 2019, 07:38
Fabien added inline comments.
test/lint/dictionary/english.json
222

Why not adding "transation": "transaction" as well ?

This revision now requires changes to proceed.Aug 26 2019, 07:38

Added "transation": "transaction" to the linter dictionary and added arc lint --everything to test plan.

nakihito added inline comments.
src/qt/editaddressdialog.h
27 ↗(On Diff #10958)

Linter change.

Fabien added inline comments.
src/qt/editaddressdialog.h
27 ↗(On Diff #10958)
This revision is now accepted and ready to land.Aug 26 2019, 19:27
This revision was automatically updated to reflect the committed changes.