Page MenuHomePhabricator
Differential D3893

Merge #12747: Fix typos
ClosedPublic
Actions

Authored by nakihito on Aug 16 2019, 19:42.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8cd5e4ccde0c: Merge #12747: Fix typos
rABC8cd5e4ccde0c: Merge #12747: Fix typos
Summary

d27327c79a Fix typos (practicalswift)

Pull request description:

Fix typos.

Tree-SHA512: f0d13d991acdec0d3adc2f091cd00ccbdda6da3c7623dfb4cbf698bac9eb6b3d88c8ad121256a96cb130f8e97bf54892f3616da0e8dc833dcf713ca7949e2801

Backport of Core PR12747
https://github.com/bitcoin/bitcoin/pull/12747/

Test Plan
make check
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12747
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7174
Build 12393: Bitcoin ABC Buildbot (legacy)
Build 12392: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 16 2019, 19:42
Owners added a reviewer: Restricted Owners Package.Aug 16 2019, 19:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 16 2019, 19:42
nakihito planned changes to this revision.Aug 16 2019, 19:43
teamcity added a comment.Aug 16 2019, 19:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 16 2019, 19:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7174: Diff 10835.Aug 16 2019, 19:49
nakihito requested review of this revision.Aug 23 2019, 20:28

The misspelled variable and function names were already correct.
See: D3306, D3243, and D3180

Fabien requested changes to this revision.Aug 26 2019, 07:38
Fabien added inline comments.
test/lint/dictionary/english.json
222

Why not adding "transation": "transaction" as well ?

This revision now requires changes to proceed.Aug 26 2019, 07:38
nakihito updated this revision to Diff 10958.Aug 26 2019, 18:21

Added "transation": "transaction" to the linter dictionary and added arc lint --everything to test plan.

teamcity added a comment.Aug 26 2019, 18:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Aug 26 2019, 18:22
nakihito added inline comments.
src/qt/editaddressdialog.h
27 ↗(On Diff #10958)

Linter change.

Harbormaster completed remote builds in B7240: Diff 10958.Aug 26 2019, 18:28
teamcity added a comment.Aug 26 2019, 18:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Aug 26 2019, 19:27
Fabien added inline comments.
src/qt/editaddressdialog.h
27 ↗(On Diff #10958)

FYI, see https://reviews.bitcoinabc.org/D3946

This revision is now accepted and ready to land.Aug 26 2019, 19:27
Closed by commit rABC8cd5e4ccde0c: Merge #12747: Fix typos (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyAug 26 2019, 20:13
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC8cd5e4ccde0c: Merge #12747: Fix typos.
Fabien mentioned this in D3946: Add a trailing comma to the Mode enum.Aug 27 2019, 06:35
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING8cd5e4ccde0c: Merge #12747: Fix typos.Sep 19 2019, 02:01

Revision Contents
Changeset List

PathSize
src/
2 lines
test/
lint/
dictionary/
1 line
util/
data/
4 lines

Diff 10835

View Options

src/addrman.h

Loading...
View Options

test/lint/dictionary/english.json

Loading...
View Options

test/util/data/bitcoin-util-test.json

Loading...