Page MenuHomePhabricator

Merge #12762: Make CKeyStore an interface
ClosedPublic

Authored by nakihito on Aug 17 2019, 00:32.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf1d523c99830: Merge #12762: Make CKeyStore an interface
rABCf1d523c99830: Merge #12762: Make CKeyStore an interface
Summary

f381299 Move CKeyStore::cs_KeyStore to CBasicKeyStore (João Barbosa)
25eb9f5 Inline CKeyStore::AddKey(const CKey &) in CBasicKeyStore (João Barbosa)

Pull request description:

Made these simplifications while reviewing #12714. This aims to make `CKeyStore` a *pure* interface:
 - no variable members - the mutex is moved to `CBasicKeyStore` which is where it is used;
 - no method implementations - `AddKey(const CKey &)` is moved to `CBasicKeyStore` which is where it is needed.

Tree-SHA512: 84e44f4390c59600e5cefa599b5464e1771c31dd4abc678ef50db8e06ffac778d692860a352918444f8bcd66430634637b6277a818a658721ffc4f381c1c6a90

Backport of Core PR12762
https://github.com/bitcoin/bitcoin/pull/12762/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12762
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7181
Build 12407: Bitcoin ABC Buildbot (legacy)
Build 12406: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 17 2019, 00:32
This revision is now accepted and ready to land.Aug 19 2019, 18:27