Page MenuHomePhabricator

Rename “OS X” to the newer “macOS” convention
ClosedPublic

Authored by Fabien on Aug 19 2019, 13:41.

Details

Summary
Since 2016, with macOS 10.12 Sierra, Mac OS X has been renamed in macOS.
It would be a nice if Bitcoin's macOS build instructions follow this
naming convention to avoid misunderstandings.

Backport of core PR13366
https://github.com/bitcoin/bitcoin/pull/13366/files

Depends on D3910.
Includes name changes to the gitian documentation which are not part of
the original PR.

Test Plan

Read it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13366
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7204
Build 12453: Bitcoin ABC Buildbot (legacy)
Build 12452: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 19 2019, 13:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2019, 13:41
jasonbcox accepted this revision.Aug 19 2019, 18:02
This revision is now accepted and ready to land.Aug 19 2019, 18:02
Fabien updated this revision to Diff 10883.Aug 20 2019, 12:29

Rebase.

jasonbcox accepted this revision.Aug 20 2019, 19:01