Page MenuHomePhabricator
Differential D3912

Rename “OS X” to the newer “macOS” convention
ClosedPublic
Actions

Authored by Fabien on Aug 19 2019, 13:41.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc1f7d37d63bf: Rename “OS X” to the newer “macOS” convention
rABCc1f7d37d63bf: Rename “OS X” to the newer “macOS” convention
Summary
Since 2016, with macOS 10.12 Sierra, Mac OS X has been renamed in macOS.
It would be a nice if Bitcoin's macOS build instructions follow this
naming convention to avoid misunderstandings.

Backport of core PR13366
https://github.com/bitcoin/bitcoin/pull/13366/files

Depends on D3910.
Includes name changes to the gitian documentation which are not part of
the original PR.

Test Plan

Read it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13366
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7204
Build 12453: Bitcoin ABC Buildbot (legacy)
Build 12452: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 19 2019, 13:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2019, 13:41
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 19 2019, 13:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 19 2019, 13:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7193: Diff 10862.Aug 19 2019, 13:47
jasonbcox accepted this revision.Aug 19 2019, 18:02
This revision is now accepted and ready to land.Aug 19 2019, 18:02
Fabien edited the summary of this revision. (Show Details)Aug 19 2019, 21:15
Fabien added a parent revision: D3910: [docs] initial QT documentation, move Qt Creator instructions.
Fabien added a child revision: D3919: release: require macOS 10.10+.Aug 20 2019, 12:12
Fabien updated this revision to Diff 10883.Aug 20 2019, 12:29

Rebase.

teamcity added a comment.Aug 20 2019, 12:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Aug 20 2019, 12:29
Fabien removed parent revisions: D3907: Remove the tested versions from the OSX build guide, D3909: docs: Update osx brew install instruction.
teamcity added a comment.Aug 20 2019, 12:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7204: Diff 10883.Aug 20 2019, 12:40
Fabien added a child revision: D3921: trivial: Fixed typos and cleaned up language.Aug 20 2019, 17:38
jasonbcox accepted this revision.Aug 20 2019, 19:01
Closed by commit rABCc1f7d37d63bf: Rename “OS X” to the newer “macOS” convention (authored by Giulio Lombardo <giulio.lombardo@gmail.com>, committed by Fabien). · Explain WhyAug 21 2019, 09:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc1f7d37d63bf: Rename “OS X” to the newer “macOS” convention.
Fabien added a commit: rSTAGINGc1f7d37d63bf: Rename “OS X” to the newer “macOS” convention.Sep 19 2019, 01:57

Revision Contents
Changeset List

PathSize
contrib/
init/
2 lines
depends/
6 lines
2 lines
doc/
4 lines
10 lines
4 lines
4 lines
gitian-building/
2 lines
2 lines
6 lines
src/
qt/
8 lines

Diff 10883

View Options

contrib/init/README.md

Loading...
View Options

depends/README.md

Loading...
View Options

depends/description.md

Loading...
View Options

doc/README.md

Loading...
View Options

doc/README_osx.md

Loading...
View Options

doc/build-osx.md

Loading...
View Options

doc/gitian-building.md

Loading...
View Options

doc/gitian-building/gitian-building-create-vm-debian.md

Loading...
View Options

doc/gitian-building/gitian-building-create-vm-fedora.md

Loading...
View Options

doc/init.md

Loading...
View Options

src/qt/README.md

Loading...