[CMAKE] Add missing -DMAC_OSX definition
ClosedPublic
Actions

Authored by Fabien on Aug 19 2019, 19:09.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING7f43e4a1dc29: [CMAKE] Add missing -DMAC_OSX definition
rABC7f43e4a1dc29: [CMAKE] Add missing -DMAC_OSX definition

Summary

This is mostly used to enable workarounds for OSX.

Test Plan

Build and cross build for OSX using CMake.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 19 2019, 19:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2019, 19:09

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7195: Diff 10866.Aug 19 2019, 19:16

Fabien added a child revision: D3919: release: require macOS 10.10+.Aug 20 2019, 12:12

Need to be defined also for native build

Move the definition to have it available for both native and cross builds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7205: Diff 10884.Aug 20 2019, 16:03

jasonbcox accepted this revision.Aug 20 2019, 16:37

This revision is now accepted and ready to land.Aug 20 2019, 16:37

Closed by commit rABC7f43e4a1dc29: [CMAKE] Add missing -DMAC_OSX definition (authored by Fabien). · Explain WhyAug 20 2019, 18:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7f43e4a1dc29: [CMAKE] Add missing -DMAC_OSX definition.

Fabien added a commit: rSTAGING7f43e4a1dc29: [CMAKE] Add missing -DMAC_OSX definition.Sep 19 2019, 01:56

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

4 lines

Diff 10893

View Options

[CMAKE] Add missing -DMAC_OSX definitionClosedPublicActions