Page MenuHomePhabricator
Differential D3919

release: require macOS 10.10+
ClosedPublic
Actions

Authored by Fabien on Aug 20 2019, 12:12.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd529b71160bd: release: require macOS 10.10+
rABCd529b71160bd: release: require macOS 10.10+
Summary

Qt 5.9.6 is incompatible with macOS < 10.10

Backport of core PR13617
https://github.com/bitcoin/bitcoin/pull/13617/files

Depends on D3912, D3913 and D3917.

Test Plan

Run a native build with autotools and cmake.
Cross build with autotools and cmake.
Run the gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13617
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7202
Build 12449: Bitcoin ABC Buildbot (legacy)
Build 12448: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 20 2019, 12:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2019, 12:12
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 20 2019, 12:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien planned changes to this revision.Aug 20 2019, 12:13

Will request for review after the Gitian and native builds have been successful.

teamcity added a comment.Aug 20 2019, 12:14

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Aug 20 2019, 12:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7202: Diff 10881.Aug 20 2019, 12:21
teamcity added a comment.Aug 20 2019, 12:25

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien requested review of this revision.Aug 20 2019, 15:57

Ready to review.

jasonbcox accepted this revision.Aug 20 2019, 19:07
This revision is now accepted and ready to land.Aug 20 2019, 19:07
Closed by commit rABCd529b71160bd: release: require macOS 10.10+ (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyAug 21 2019, 09:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd529b71160bd: release: require macOS 10.10+.
Fabien mentioned this in D4037: Fix the build-osx target for the depends subsystem.Sep 11 2019, 13:49
Fabien mentioned this in rABC4a2954fca490: Fix the build-osx target for the depends subsystem.Sep 11 2019, 13:58
Fabien added a commit: rSTAGINGd529b71160bd: release: require macOS 10.10+.Sep 19 2019, 01:58
Fabien mentioned this in rSTAGING4a2954fca490: Fix the build-osx target for the depends subsystem.Sep 19 2019, 02:13

Revision Contents
Changeset List

PathSize
cmake/
platforms/
4 lines
contrib/
gitian-descriptors/
2 lines
depends/
2 lines
2 lines
hosts/
2 lines
doc/
3 lines
share/
qt/
2 lines
src/
compat/
4 lines
qt/
1 line
16 lines
50 lines
2 lines

Diff 10881

View Options

cmake/platforms/OSX.cmake

Loading...
View Options

contrib/gitian-descriptors/gitian-osx.yml

Loading...
View Options

depends/Makefile

Loading...
View Options

depends/README.md

Loading...
View Options

depends/hosts/darwin.mk

Loading...
View Options

doc/release-notes.md

Loading...
View Options

share/qt/Info.plist.in

Loading...
View Options

src/compat/byteswap.h

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/util.cpp

Loading...