Page MenuHomePhabricator
Differential D3954

Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0
ClosedPublic
Actions

Authored by nakihito on Aug 28 2019, 00:51.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGa402ac14866f: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0
rABCa402ac14866f: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0
Summary

b86730a util: Remove designator initializer from ScheduleBatchPriority (Wladimir J. van der Laan)
cff66e6 util: Pass pthread_self() to pthread_setschedparam instead of 0 (Wladimir J. van der Laan)

Pull request description:

Nowhere in the man page of `pthread_setschedparam` it is mentioned that `0` is a valid value. The example uses `pthread_self()`, so should we.

(noticed by Anthony Towns)
Fixes #12915.

Tree-SHA512: 249e93b1ae7e3ba28de6ee6288400b91d21ca1b4ca41d82211f6c9609b62deb5ac87182c7bf08471d3a3e0c1af314c9ecd41f8ae864febe963b1de8a816dd82f

Backport of Core PR12923
https://github.com/bitcoin/bitcoin/pull/12923/

Depends on D3953

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 28 2019, 00:51
Owners added a reviewer: Restricted Owners Package.Aug 28 2019, 00:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 00:52
teamcity added a comment.Aug 28 2019, 00:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Aug 28 2019, 00:52
nakihito added a parent revision: D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..
teamcity added a comment.Aug 28 2019, 00:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito mentioned this in D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..Aug 28 2019, 00:54
teamcity added a comment.Aug 28 2019, 01:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7251: Diff 10977.Aug 28 2019, 01:06
deadalnix accepted this revision.Aug 28 2019, 14:11
This revision is now accepted and ready to land.Aug 28 2019, 14:11
nakihito updated this revision to Diff 11006.Aug 28 2019, 19:09

Rebased.

teamcity added a comment.Aug 28 2019, 19:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito updated this revision to Diff 11009.Aug 28 2019, 19:16

Rebase.

teamcity added a comment.Aug 28 2019, 19:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 28 2019, 19:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 28 2019, 19:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7267: Diff 11006.Aug 28 2019, 19:21
Harbormaster completed remote builds in B7270: Diff 11009.Aug 28 2019, 19:43
teamcity added a comment.Aug 28 2019, 19:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABCa402ac14866f: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0 (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 29 2019, 18:27
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCa402ac14866f: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGa402ac14866f: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.Sep 19 2019, 02:05

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 11031

View Options

src/util.cpp

Loading...