Remove unused variables in shell scripts.
ClosedPublic
Actions

Authored by Fabien on Aug 28 2019, 08:34.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING341e69d34c40: Remove unused variables in shell scripts.
rABC341e69d34c40: Remove unused variables in shell scripts.

Summary

Remove unused variables in shell scripts. Use _ where we don't care
about the result.

Backport of core PR10771 and PR11649
https://github.com/bitcoin/bitcoin/pull/10771/files
https://github.com/bitcoin/bitcoin/pull/11649/files

Depends on D3955.

Not much change remaining as most of the files have been removed.

Test Plan

Run the git-subtree-check.sh script. It will not output GOOD as we
made changes to all the subtree libraries (at least code formatting).

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10771

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7254
Build 12553: Bitcoin ABC Buildbot (legacy)
Build 12552: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 28 2019, 08:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 08:34

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7254: Diff 10983.Aug 28 2019, 08:42

Fabien added a child revision: D3959: Add shell script linting: Check for shellcheck warnings in shell scripts.Aug 28 2019, 09:56

deadalnix accepted this revision.Aug 28 2019, 12:23

This revision is now accepted and ready to land.Aug 28 2019, 12:23

Closed by commit rABC341e69d34c40: Remove unused variables in shell scripts. (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyAug 28 2019, 12:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC341e69d34c40: Remove unused variables in shell scripts..

Fabien added a commit: rSTAGING341e69d34c40: Remove unused variables in shell scripts..Sep 19 2019, 02:02

Revision Contents
Changeset List

Path

Size

test/

lint/

git-subtree-check.sh

2 lines

Diff 10983

View Options

test/lint/git-subtree-check.sh

Remove unused variables in shell scripts.ClosedPublicActions