Page MenuHomePhabricator

[net] Tighten scope in net_processing
ClosedPublic

Authored by deadalnix on Aug 28 2019, 17:37.

Details

Summary

This is a backport of Core PR13417:

  • Rescope g_enable_bip61 to net_processing
  • [move-only] Move things only referenced in net_processing out of header file
  • Restrict as much as possible in net_processing to translation unit

Mark everything else static or in an anonymous namespace.

  • Make g_enable_bip61 a member variable of PeerLogicValidation
Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13417
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7265
Build 12575: Bitcoin ABC Buildbot (legacy)
Build 12574: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Aug 30 2019, 13:17
Fabien added a subscriber: Fabien.

Otherwise LGTM.

src/net_processing.cpp
1070

There is a dependency missing here: https://github.com/bitcoin/bitcoin/pull/12603/files

This revision now requires changes to proceed.Aug 30 2019, 13:17
This revision is now accepted and ready to land.Sep 12 2019, 18:27
This revision was automatically updated to reflect the committed changes.