Page MenuHomePhabricator
Differential D3965

[net] Tighten scope in net_processing
ClosedPublic
Actions

Authored by deadalnix on Aug 28 2019, 17:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING744d23d142c4: [net] Tighten scope in net_processing
rABC744d23d142c4: [net] Tighten scope in net_processing
Summary

This is a backport of Core PR13417:

  • Rescope g_enable_bip61 to net_processing
  • [move-only] Move things only referenced in net_processing out of header file
  • Restrict as much as possible in net_processing to translation unit

Mark everything else static or in an anonymous namespace.

  • Make g_enable_bip61 a member variable of PeerLogicValidation
Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13417
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7420
Build 12883: Bitcoin ABC Buildbot (legacy)
Build 12882: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 28 2019, 17:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 17:37
teamcity added a comment.Aug 28 2019, 17:37

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7265: Diff 11001.Aug 28 2019, 17:44
teamcity added a comment.Aug 28 2019, 17:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested changes to this revision.Aug 30 2019, 13:17
Fabien added a subscriber: Fabien.

Otherwise LGTM.

src/net_processing.cpp
1070 ↗(On Diff #11001)

There is a dependency missing here: https://github.com/bitcoin/bitcoin/pull/12603/files

This revision now requires changes to proceed.Aug 30 2019, 13:17
deadalnix updated this revision to Diff 11045.Aug 30 2019, 13:26

rebase

teamcity added a comment.Aug 30 2019, 13:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 30 2019, 13:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7291: Diff 11045.Aug 30 2019, 13:39
deadalnix updated this revision to Diff 11243.Sep 12 2019, 15:11

Rebase on top of D4052

teamcity added a comment.Sep 12 2019, 15:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 15:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7420: Diff 11243.Sep 12 2019, 15:20
Fabien accepted this revision.Sep 12 2019, 18:27
This revision is now accepted and ready to land.Sep 12 2019, 18:27
Closed by commit rABC744d23d142c4: [net] Tighten scope in net_processing (authored by Jesse Cohen <jc@jc.lol>, committed by deadalnix). · Explain WhySep 13 2019, 06:14
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC744d23d142c4: [net] Tighten scope in net_processing.
deadalnix added a commit: rSTAGING744d23d142c4: [net] Tighten scope in net_processing.Sep 19 2019, 02:18

Revision Contents
Changeset List

Diff 11243

View Options

src/init.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...