During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after
ClosedPublic
Actions

Authored by fpelliccioni on Sep 3 2019, 18:19.

Details

Reviewers

Fabien
deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon…
rABC966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon…

Summary

Pruning forces a chainstate flush, which can defeat the dbcache and harm performance significantly.

Backport of Bitcoin Core PR11658
https://github.com/bitcoin/bitcoin/pull/11658

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature-backport-9a1ad2c5c

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7305
Build 12653: Bitcoin ABC Buildbot (legacy)
Build 12652: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 3 2019, 18:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2019, 18:19

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7305: Diff 11068.Sep 3 2019, 18:26

jasonbcox accepted this revision.Sep 4 2019, 20:24

This revision is now accepted and ready to land.Sep 4 2019, 20:24

Closed by commit rABC966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon… (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by fpelliccioni). · Explain WhySep 5 2019, 19:20

This revision was automatically updated to reflect the committed changes.

fpelliccioni added a commit: rABC966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon….

fpelliccioni added a commit: rSTAGING966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon….Sep 19 2019, 02:08

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

10 lines

Diff 11068

View Options

During IBD, when doing pruning, prune 10% extra to avoid pruning again soon afterClosedPublicActions