Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan
ClosedPublic
Actions

Authored by nakihito on Sep 6 2019, 17:55.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGbe3bf6094d7c: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan
rABCbe3bf6094d7c: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan

Summary

3fe836b78d504942e8850b607453886969f57e27 [moveonly] Extract RescanWallet to handle a simple rescan (Ben Woosley)

Pull request description:

Where the outcome does not depend on the result, apart from a simple
success check.

Tree-SHA512: e0d29c6fc0c7f99a730289e5a80deb586b2848aead56b5198a71ef01f65374812468dfd57be0b8b076eb9be4090d5101d28d979a1d5c3d2f1caeca77b303e90e

Backport of Core PR12658
https://github.com/bitcoin/bitcoin/pull/13658/

Test Plan

make check
./bitcoin-qt -> help -> debug -> console -> rescanblockchain
./bitcoind
./bitcoin-cli rescanblockchain

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13658

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7355
Build 12753: Bitcoin ABC Buildbot (legacy)
Build 12752: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 6 2019, 17:55

Owners added a reviewer: Restricted Owners Package.Sep 6 2019, 17:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2019, 17:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7355: Diff 11143.Sep 6 2019, 18:04

jasonbcox accepted this revision.Sep 6 2019, 21:42

This revision is now accepted and ready to land.Sep 6 2019, 21:42

Closed by commit rABCbe3bf6094d7c: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhySep 6 2019, 22:58

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCbe3bf6094d7c: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGbe3bf6094d7c: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.Sep 19 2019, 02:11

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

59 lines

wallet.h

2 lines

Diff 11143

View Options

src/wallet/rpcdump.cpp