Page MenuHomePhabricator

Merge #13149: Handle unsuccessful fseek(...):s
ClosedPublic

Authored by nakihito on Fri, Sep 6, 18:21.

Details

Summary

20ce5af Print a log message if we fail to shrink the debug log file (practicalswift)
29c9bdc Handle unsuccessful fseek(...):s (practicalswift)

Pull request description:

Handle unsuccessful `fseek(...)`:s.

**Note to reviewers:** What is the most appropriate course of actions for each of these unsuccessful `fseek(...)`:s?

Tree-SHA512: 5b3d82dbdd15d434d3f08dcb4df62888da4df8541d2586f56a4e529083005f6782c39e10645acd1ec403da83061bbfd8dbf2dddc66e09268d410ad0918c61876

Backport of Core PR13149
https://github.com/bitcoin/bitcoin/pull/13149/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, Sep 6, 18:21
Owners added a reviewer: Restricted Owners Package.Fri, Sep 6, 18:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 6, 18:21
deadalnix requested changes to this revision.Sun, Sep 8, 12:10

Mention PR13149

This revision now requires changes to proceed.Sun, Sep 8, 12:10
nakihito requested review of this revision.Mon, Sep 9, 17:06
nakihito edited the summary of this revision. (Show Details)
Fabien accepted this revision.Tue, Sep 10, 06:37
deadalnix accepted this revision.Sat, Sep 14, 08:32
This revision is now accepted and ready to land.Sat, Sep 14, 08:32
This revision was landed with ongoing or failed builds.Mon, Sep 16, 23:45
This revision was automatically updated to reflect the committed changes.