Page MenuHomePhabricator
Differential D4021

Merge #13149: Handle unsuccessful fseek(...):s
ClosedPublic
Actions

Authored by nakihito on Sep 6 2019, 18:21.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGfddf954d9498: Merge #13149: Handle unsuccessful fseek(...):s
rABCfddf954d9498: Merge #13149: Handle unsuccessful fseek(...):s
Summary

20ce5af Print a log message if we fail to shrink the debug log file (practicalswift)
29c9bdc Handle unsuccessful fseek(...):s (practicalswift)

Pull request description:

Handle unsuccessful `fseek(...)`:s.

**Note to reviewers:** What is the most appropriate course of actions for each of these unsuccessful `fseek(...)`:s?

Tree-SHA512: 5b3d82dbdd15d434d3f08dcb4df62888da4df8541d2586f56a4e529083005f6782c39e10645acd1ec403da83061bbfd8dbf2dddc66e09268d410ad0918c61876

Backport of Core PR13149
https://github.com/bitcoin/bitcoin/pull/13149/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13149
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7357
Build 12757: Bitcoin ABC Buildbot (legacy)
Build 12756: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 6 2019, 18:21
Owners added a reviewer: Restricted Owners Package.Sep 6 2019, 18:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2019, 18:21
teamcity added a comment.Sep 6 2019, 18:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B7357: Diff 11146!Sep 6 2019, 18:23
teamcity added a comment.Sep 6 2019, 18:23

Build Bitcoin-ABC / Diffs / Diff Testing failed.

teamcity added a comment.Sep 6 2019, 18:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 6 2019, 18:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix requested changes to this revision.Sep 8 2019, 12:10

Mention PR13149

This revision now requires changes to proceed.Sep 8 2019, 12:10
nakihito requested review of this revision.Sep 9 2019, 17:06
nakihito edited the summary of this revision. (Show Details)
Fabien accepted this revision.Sep 10 2019, 06:37
deadalnix accepted this revision.Sep 14 2019, 08:32
This revision is now accepted and ready to land.Sep 14 2019, 08:32
This revision was landed with ongoing or failed builds.Sep 16 2019, 23:45
Closed by commit rABCfddf954d9498: Merge #13149: Handle unsuccessful fseek(...):s (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain Why
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCfddf954d9498: Merge #13149: Handle unsuccessful fseek(...):s.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGfddf954d9498: Merge #13149: Handle unsuccessful fseek(...):s.Sep 19 2019, 02:24

Revision Contents
Changeset List

PathSize
src/
index/
4 lines
6 lines
4 lines

Diff 11146

View Options

src/index/txindex.cpp

Loading...
View Options

src/logging.cpp

Loading...
View Options

src/util.cpp

Loading...