Page MenuHomePhabricator
Differential D4022

Merge #12503: [RPC] createmultisig no longer takes addresses
ClosedPublic
Actions

Authored by nakihito on Sep 6 2019, 18:33.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd0c43baa4437: Merge #12503: [RPC] createmultisig no longer takes addresses
rABCd0c43baa4437: Merge #12503: [RPC] createmultisig no longer takes addresses
Summary

e4c924c517 createmultisig no longer takes addresses (Gregory Sanders)

Pull request description:
Removed mention of address in help text.

Tree-SHA512: a6a752ef2282c5c893dd1a6ff5ccab42d3de1989847af627d82d41605ea19abc0aaf68567a62b6478933ba7eea09f911087b410ba7d3a815331ef15ec1ff9df0

Backport of Core PR12503
https://github.com/bitcoin/bitcoin/pull/12503/

Test Plan
make check
./bitcoind
./bitcoin-cli help createmultisig

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12503
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7358
Build 12759: Bitcoin ABC Buildbot (legacy)
Build 12758: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 6 2019, 18:33
Owners added a reviewer: Restricted Owners Package.Sep 6 2019, 18:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2019, 18:33
teamcity added a comment.Sep 6 2019, 18:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a comment.Sep 6 2019, 18:35

using addresses in createmultisig was deprecated in D2002 and the deprecated code was removed in D3978.

teamcity added a comment.Sep 6 2019, 18:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7358: Diff 11147.Sep 6 2019, 18:40
jasonbcox accepted this revision.Sep 6 2019, 20:50
This revision is now accepted and ready to land.Sep 6 2019, 20:50
Closed by commit rABCd0c43baa4437: Merge #12503: [RPC] createmultisig no longer takes addresses (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhySep 6 2019, 23:06
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCd0c43baa4437: Merge #12503: [RPC] createmultisig no longer takes addresses.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGd0c43baa4437: Merge #12503: [RPC] createmultisig no longer takes addresses.Sep 19 2019, 02:11

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines

Diff 11147

View Options

src/rpc/misc.cpp

Loading...