Page MenuHomePhabricator

Hardcoded seeds update
ClosedPublic

Authored by sickpig on Jul 31 2017, 19:07.

Details

Summary

Starting from the data fetched by the seeder's crawlers
this commit will add a list of know and working BCC compliant
nodes to src/chainparamsseeds.h.

The process to follow to update the file is the following

curl -Ls https://gist.githubusercontent.com/sickpig/2c98c30ca96f19c617328bb87c00e7c0/raw/51b697c408167aba182173bf5448c7c8c5e0403e/seeds_bcc_main.txt > seeds_bcc_main
python3 ./contrib/seeds/makeseeds.py < seeds_bcc_main.txt > nodes_main.txt
touch node_tests.txt
python3 ./contrib/seeds/generate-seeds.py . > src/chainparamsseeds.h

The data fetched from the git gist is a dump of the internal list of
nodes stored by the btccash-seeder.bitcoinunlimited.info.

In the process contrib/seeds/makeseeds.py has been adapted to
handle the BCC implementations useragent (BUcash, XT, ABC and Classic)
and a bunch of filters rules has been relaxed due to the fact we
are still in the bootstrap step.

Test Plan

reproduce the changes applied to src/chainparamsseeds.h using the steps listed above

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You did only update the script, not the generated file.

Also make sure there is @generated in the comment in the header of the generated file, so phabricator knows to mark it as generated.

deadalnix requested changes to this revision.Jul 31 2017, 19:26
This revision now requires changes to proceed.Jul 31 2017, 19:26
sickpig edited edge metadata.

Forgot to regenerate src/chainparamsseeds.h.
Make sure there is @generated in the comment in the header of src/chainparamsseeds.h.

Ok please update the comment, otherwise, LGTM.

contrib/seeds/makeseeds.py
36 ↗(On Diff #1002)

Please comment on what this regex do. Not what how you changed it from the previous version.

This revision is now accepted and ready to land.Jul 31 2017, 20:29

Update comments in contrib/seeds/makeseeds.py

contrib/seeds/makeseeds.py
36 ↗(On Diff #1002)

typo: used

Also to only select sounds better than to select only

This revision was automatically updated to reflect the committed changes.