Page MenuHomePhabricator

Merge #13079: Fix rescanblockchain rpc to properly report progress
ClosedPublic

Authored by nakihito on Sep 19 2019, 17:52.

Details

Summary

16be13345 Fix rescanblockchain rpc to property report progress (Ben Woosley)

Pull request description:

Previously it assumed tip in all cases. This also extracts a RescanVerificationProgress helper object whose role is to manage reporting, in order to simplify ScanForWalletTransactions - more lines in total, but much simpler to follow the core logic.

Tree-SHA512: 5ebed0c56fae4ccfe613ff1d7082cb6da5a86635a8993ed3af70b500a4ea43074121aea9219b2f0321fbfeb7efcb964bdc2199297a64ca0fa85d9d07aa637d40

Backport of Core PR13079
https://github.com/bitcoin/bitcoin/pull/13079/

Test Plan
make check
./bitcoind --printtoconsole
./bitcoin-cli rescanblockchain 0 1300000

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Sep 19 2019, 17:52
Owners added a reviewer: Restricted Owners Package.Sep 19 2019, 17:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2019, 17:52
nakihito planned changes to this revision.Sep 19 2019, 17:52
nakihito requested review of this revision.Sep 19 2019, 22:01
Fabien requested changes to this revision.Sep 20 2019, 06:26

The test plan is not testing the issue is fixed.
The behavior is changed when there is a partial rescan with some stop height, not a full rescan.

This revision now requires changes to proceed.Sep 20 2019, 06:26
nakihito requested review of this revision.Sep 20 2019, 18:42
nakihito edited the test plan for this revision. (Show Details)

Fixed test plan.

deadalnix accepted this revision.Sep 21 2019, 12:04
Fabien accepted this revision.Sep 22 2019, 10:41
This revision is now accepted and ready to land.Sep 22 2019, 10:41