Page MenuHomePhabricator
Differential D4112

Merge #13079: Fix rescanblockchain rpc to properly report progress
ClosedPublic
Actions

Authored by nakihito on Sep 19 2019, 17:52.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd559f01c7769: Merge #13079: Fix rescanblockchain rpc to properly report progress
rABCd559f01c7769: Merge #13079: Fix rescanblockchain rpc to properly report progress
Summary

16be13345 Fix rescanblockchain rpc to property report progress (Ben Woosley)

Pull request description:

Previously it assumed tip in all cases. This also extracts a RescanVerificationProgress helper object whose role is to manage reporting, in order to simplify ScanForWalletTransactions - more lines in total, but much simpler to follow the core logic.

Tree-SHA512: 5ebed0c56fae4ccfe613ff1d7082cb6da5a86635a8993ed3af70b500a4ea43074121aea9219b2f0321fbfeb7efcb964bdc2199297a64ca0fa85d9d07aa637d40

Backport of Core PR13079
https://github.com/bitcoin/bitcoin/pull/13079/

Test Plan
make check
./bitcoind --printtoconsole
./bitcoin-cli rescanblockchain 0 1300000

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13079
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7515
Build 13070: Bitcoin ABC Buildbot (legacy)
Build 13069: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 19 2019, 17:52
Owners added a reviewer: Restricted Owners Package.Sep 19 2019, 17:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2019, 17:52
nakihito planned changes to this revision.Sep 19 2019, 17:52
teamcity added a comment.Sep 19 2019, 17:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 18:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7515: Diff 13017.Sep 19 2019, 18:01
nakihito requested review of this revision.Sep 19 2019, 22:01
Fabien requested changes to this revision.Sep 20 2019, 06:26

The test plan is not testing the issue is fixed.
The behavior is changed when there is a partial rescan with some stop height, not a full rescan.

This revision now requires changes to proceed.Sep 20 2019, 06:26
nakihito requested review of this revision.Sep 20 2019, 18:42
nakihito edited the test plan for this revision. (Show Details)

Fixed test plan.

deadalnix accepted this revision.Sep 21 2019, 12:04
Fabien accepted this revision.Sep 22 2019, 10:41
This revision is now accepted and ready to land.Sep 22 2019, 10:41
Closed by commit rABCd559f01c7769: Merge #13079: Fix rescanblockchain rpc to properly report progress (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by nakihito). · Explain WhySep 23 2019, 17:20
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCd559f01c7769: Merge #13079: Fix rescanblockchain rpc to properly report progress.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGd559f01c7769: Merge #13079: Fix rescanblockchain rpc to properly report progress.Sep 27 2019, 22:48

Revision Contents
Changeset List

PathSize
src/
wallet/
40 lines

Diff 13017

View Options

src/wallet/wallet.cpp

Loading...