Differential D4115

Use std::make_unique more consistently
ClosedPublic
Actions

Authored by deadalnix on Sep 20 2019, 13:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING4a43c7ee730f: Use std::make_unique more consistently
rABC4a43c7ee730f: Use std::make_unique more consistently

Summary

Chane several use of std::unique_ptr<Foo>(new Foo()) to use std::make_unqiue

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

makeunique

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7521
Build 13082: Bitcoin ABC Buildbot (legacy)
Build 13081: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 20 2019, 13:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 13:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7521: Diff 13030.Sep 20 2019, 13:34

Fabien accepted this revision.Sep 20 2019, 14:45

This revision is now accepted and ready to land.Sep 20 2019, 14:45

Closed by commit rABC4a43c7ee730f: Use std::make_unique more consistently (authored by deadalnix). · Explain WhySep 20 2019, 16:01

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4a43c7ee730f: Use std::make_unique more consistently.

deadalnix added a commit: rSTAGING4a43c7ee730f: Use std::make_unique more consistently.Sep 27 2019, 22:45

Revision Contents
Changeset List

Path

Size

src/

httpserver.cpp

2 lines

init.cpp

6 lines

radix.h

3 lines

test/

net_tests.cpp

12 lines

work_comparator_tests.cpp

4 lines

Diff 13030

View Options

src/httpserver.cpp

View Options

src/init.cpp

View Options

src/radix.h

View Options

src/test/net_tests.cpp

View Options

src/test/work_comparator_tests.cpp

Use std::make_unique more consistentlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13030

src/httpserver.cpp

src/init.cpp

src/radix.h

src/test/net_tests.cpp

src/test/work_comparator_tests.cpp

Use std::make_unique more consistently
ClosedPublic
Actions

Revision Contents
Changeset List