Page MenuHomePhabricator

wallet: Use shared pointer to retain wallet instance

Authored by deadalnix on Sep 22 2019, 21:54.



This is a backport of Core PR13063

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 22 2019, 21:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2019, 21:54
Fabien requested changes to this revision.Sep 23 2019, 08:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
309 ↗(On Diff #13072)

Why ?

4366 ↗(On Diff #13072)

There is backport missing here:

This revision now requires changes to proceed.Sep 23 2019, 08:37
deadalnix requested review of this revision.Sep 23 2019, 11:01
deadalnix added inline comments.
4366 ↗(On Diff #13072)

It doesn't look like to me this backport is a dependence on that patch.

deadalnix updated this revision to Diff 13080.Sep 23 2019, 11:06

Rebase, fix conflicts, remove prev_version

Fabien added inline comments.Sep 23 2019, 11:07
4366 ↗(On Diff #13072)

Then you can remove this line, as it adds an unused variable without the above mentioned backport.

Fabien accepted this revision.Sep 23 2019, 11:07
This revision is now accepted and ready to land.Sep 23 2019, 11:07