Page MenuHomePhabricator

wallet: Use shared pointer to retain wallet instance
ClosedPublic

Authored by deadalnix on Sun, Sep 22, 21:54.

Details

Summary

This is a backport of Core PR13063

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sun, Sep 22, 21:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Sep 22, 21:54
Fabien requested changes to this revision.Mon, Sep 23, 08:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/node.cpp
309 ↗(On Diff #13072)

Why ?

src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

There is backport missing here:
https://github.com/bitcoin/bitcoin/pull/12560

This revision now requires changes to proceed.Mon, Sep 23, 08:37
deadalnix requested review of this revision.Mon, Sep 23, 11:01
deadalnix added inline comments.
src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

It doesn't look like to me this backport is a dependence on that patch.

deadalnix updated this revision to Diff 13080.Mon, Sep 23, 11:06

Rebase, fix conflicts, remove prev_version

Fabien added inline comments.Mon, Sep 23, 11:07
src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

Then you can remove this line, as it adds an unused variable without the above mentioned backport.

Fabien accepted this revision.Mon, Sep 23, 11:07
This revision is now accepted and ready to land.Mon, Sep 23, 11:07