Page MenuHomePhabricator
Differential D4134

wallet: Use shared pointer to retain wallet instance
ClosedPublic
Actions

Authored by deadalnix on Sep 22 2019, 21:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5fe43f2303a1: wallet: Use shared pointer to retain wallet instance
rABC5fe43f2303a1: wallet: Use shared pointer to retain wallet instance
Summary

This is a backport of Core PR13063

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13063
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7550
Build 13140: Bitcoin ABC Buildbot (legacy)
Build 13139: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 22 2019, 21:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2019, 21:54
teamcity added a comment.Sep 22 2019, 21:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 22 2019, 22:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7547: Diff 13072.Sep 22 2019, 22:07
Fabien requested changes to this revision.Sep 23 2019, 08:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/node.cpp
309 ↗(On Diff #13072)

Why ?

src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

There is backport missing here:
https://github.com/bitcoin/bitcoin/pull/12560

This revision now requires changes to proceed.Sep 23 2019, 08:37
deadalnix requested review of this revision.Sep 23 2019, 11:01
deadalnix added inline comments.
src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

It doesn't look like to me this backport is a dependence on that patch.

deadalnix updated this revision to Diff 13080.Sep 23 2019, 11:06

Rebase, fix conflicts, remove prev_version

Fabien added inline comments.Sep 23 2019, 11:07
src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

Then you can remove this line, as it adds an unused variable without the above mentioned backport.

Fabien accepted this revision.Sep 23 2019, 11:07
This revision is now accepted and ready to land.Sep 23 2019, 11:07
teamcity added a comment.Sep 23 2019, 11:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 23 2019, 11:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7550: Diff 13080.Sep 23 2019, 11:33
Closed by commit rABC5fe43f2303a1: wallet: Use shared pointer to retain wallet instance (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by deadalnix). · Explain WhySep 23 2019, 11:33
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC5fe43f2303a1: wallet: Use shared pointer to retain wallet instance.
nakihito mentioned this in D4121: Merge #13063: Use shared pointer to retain wallet instance.Sep 23 2019, 21:19
deadalnix added a commit: rSTAGING5fe43f2303a1: wallet: Use shared pointer to retain wallet instance.Sep 27 2019, 22:47
nakihito mentioned this in D4171: Merge #12560: [wallet] Upgrade path for non-HD wallets to HD.Sep 27 2019, 23:28

Revision Contents
Changeset List

PathSize
src/
interfaces/
9 lines
2 lines
6 lines
qt/
test/
20 lines
33 lines
9 lines
wallet/
11 lines
31 lines
3 lines
186 lines
test/
33 lines
14 lines
37 lines
2 lines

Diff 13080

View Options

src/interfaces/node.cpp

Loading...
View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/test/addressbooktests.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/ui_interface.h

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...