Page MenuHomePhabricator

Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH
ClosedPublic

Authored by nakihito on Wed, Sep 25, 18:45.

Details

Summary

7de1de7 Add new fee structure with all sub-fields denominated in BTC (mryandao)

Pull request description:

the denomination for `fee` is current in btc while the other such as `decendentFee` and `ancestorFee` are in satoshis.

Tree-SHA512: e428f6dca1d339f89ab73e38ce5903f5465c46b159069d9bcc3f8b1140fe6657fa49a11abe0088e9f7ba9999f64af72a349a4735bf5eaa61b8e4a185b23543f3

Backport of Core PR12240
https://github.com/bitcoin/bitcoin/pull/12240/

Also included PR13109 and PR13124 (small typo fixes)
https://github.com/bitcoin/bitcoin/pull/13109/
https://github.com/bitcoin/bitcoin/pull/13124/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Wed, Sep 25, 18:45
Owners added a reviewer: Restricted Owners Package.Wed, Sep 25, 18:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 25, 18:45
nakihito planned changes to this revision.Wed, Sep 25, 18:45
nakihito updated this revision to Diff 13141.Wed, Sep 25, 19:01

Applied another typo fix changes.

nakihito planned changes to this revision.Wed, Sep 25, 19:01
nakihito retitled this revision from Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC to Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.Wed, Sep 25, 19:02
nakihito edited the summary of this revision. (Show Details)Wed, Sep 25, 19:23
nakihito requested review of this revision.Wed, Sep 25, 21:15
jasonbcox requested changes to this revision.Tue, Oct 1, 18:44
jasonbcox added inline comments.
doc/release-notes.md
6 ↗(On Diff #13141)

Ideally, this would be formatted so that it's readable in 80-char wide terminals. Add some newlines to break this up.

This revision now requires changes to proceed.Tue, Oct 1, 18:44
nakihito updated this revision to Diff 13308.Tue, Oct 1, 20:58

Reformatted release notes.

jasonbcox requested changes to this revision.Tue, Oct 1, 21:26
jasonbcox added inline comments.
doc/release-notes.md
10 ↗(On Diff #13308)

This still isn't right. Markdown uses whitespace to group bullet-pointed, multi-line content. See old release notes as examples.

This revision now requires changes to proceed.Tue, Oct 1, 21:26
nakihito updated this revision to Diff 13309.Tue, Oct 1, 22:05

Further release-notes formatting.

jasonbcox accepted this revision.Tue, Oct 1, 22:07
This revision is now accepted and ready to land.Tue, Oct 1, 22:07