Page MenuHomePhabricator
Differential D4173

doxygen: Fix member comments
ClosedPublic
Actions

Authored by fpelliccioni on Sep 27 2019, 17:58.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING44a1e1cd6c81: doxygen: Fix member comments
rABC44a1e1cd6c81: doxygen: Fix member comments
Summary

Trailing comments must be indicted with the caret //!<.

Backport of Bitcoin Core PR14331
https://github.com/bitcoin/bitcoin/pull/14331

Test Plan
doxygen doc/Doxyfile

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-011c39c29
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7616
Build 13272: Bitcoin ABC Buildbot (legacy)
Build 13271: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 27 2019, 17:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2019, 17:58
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 27 2019, 17:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni edited the test plan for this revision. (Show Details)Sep 27 2019, 17:59
Harbormaster completed remote builds in B7616: Diff 13183.Sep 27 2019, 18:08
teamcity added a comment.Sep 27 2019, 18:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Sep 27 2019, 18:10
jasonbcox added a subscriber: jasonbcox.

The comments in txmempool.h are no longer trailing, but I don't think gaining ownership on those comments is worth it.

This revision is now accepted and ready to land.Sep 27 2019, 18:10
Closed by commit rABC44a1e1cd6c81: doxygen: Fix member comments (authored by MarcoFalke <falke.marco@gmail.com>, committed by fpelliccioni). · Explain WhySep 30 2019, 13:20
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC44a1e1cd6c81: doxygen: Fix member comments.
fpelliccioni added a commit: rSTAGING44a1e1cd6c81: doxygen: Fix member comments.Oct 9 2019, 20:10

Revision Contents
Changeset List

PathSize
src/
2 lines
26 lines
14 lines

Diff 13183

View Options

src/net_processing.h

Loading...
View Options

src/netbase.cpp

Loading...
View Options

src/txmempool.h

Loading...