Page MenuHomePhabricator

utils: Convert Windows args to utf-8 string
ClosedPublic

Authored by deadalnix on Sep 27 2019, 20:34.

Details

Summary

This is a backport of Core PR13883

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13883
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7631
Build 13302: Bitcoin ABC Buildbot (legacy)
Build 13301: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 27 2019, 20:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2019, 20:34
deadalnix edited the test plan for this revision. (Show Details)Sep 27 2019, 20:34
jasonbcox requested changes to this revision.Sep 27 2019, 21:48
jasonbcox added a subscriber: jasonbcox.

The backport looks ok comparing to the original PR, but the test is broken.

This revision now requires changes to proceed.Sep 27 2019, 21:48
deadalnix updated this revision to Diff 13266.Sep 28 2019, 13:46

Try something

deadalnix updated this revision to Diff 13267.Sep 28 2019, 14:17

try more shit

I have no idea what's happening on CI, none of this is reproducing outside of CI.

Fabien added a subscriber: Fabien.Sep 30 2019, 17:08

I tried to reproduce on a fresh Debian Stretch, no success.
I will try to install the agent packages and run again.

jasonbcox accepted this revision.Oct 1 2019, 20:26
This revision is now accepted and ready to land.Oct 1 2019, 20:26
This revision was automatically updated to reflect the committed changes.