Page MenuHomePhabricator

utils: Convert Windows args to utf-8 string
ClosedPublic

Authored by deadalnix on Sep 27 2019, 20:34.

Details

Summary

This is a backport of Core PR13883

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13883
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7656
Build 13351: Bitcoin ABC Buildbot (legacy)
Build 13350: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Sep 27 2019, 21:48
jasonbcox added a subscriber: jasonbcox.

The backport looks ok comparing to the original PR, but the test is broken.

This revision now requires changes to proceed.Sep 27 2019, 21:48

I have no idea what's happening on CI, none of this is reproducing outside of CI.

I tried to reproduce on a fresh Debian Stretch, no success.
I will try to install the agent packages and run again.

This revision is now accepted and ready to land.Oct 1 2019, 20:26