Page MenuHomePhabricator

Added more explicit instructions for release tagging
ClosedPublic

Authored by jasonbcox on Sep 30 2019, 16:26.

Details

Summary

See title.

Test Plan

Read it and try it on a forked repo.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Sep 30 2019, 16:26
jasonbcox added inline comments.Sep 30 2019, 16:28
doc/release-process.md
34 ↗(On Diff #13276)

Note that the following are not acceptable solutions:

  • git push github vM.m.r:master because this only pushes the tag and does fast-forward master.
  • git push github master --tags because pushing all tags is poor design. I personally have applied non-release tags on local repo with which I don't intend on garbaging up the public repo.
Fabien accepted this revision.Oct 1 2019, 06:43
This revision is now accepted and ready to land.Oct 1 2019, 06:43
This revision was automatically updated to reflect the committed changes.