Similar in spirit to https://github.com/bitcoin/bitcoin/pull/13863/commits/414326952cd6086ebc491413e8cf58a60ad857a4#diff-41e4d53455228facb9cfa198baaa2440
This allows us to explicitly set the codeset to UTF-8.
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGING7af048cfc2b0: Added support for `export LC_ALL=C.UTF-8` to the shell linter
rABC7af048cfc2b0: Added support for `export LC_ALL=C.UTF-8` to the shell linter
arc lint on the following cases:
- script with export LC_ALL=C
- script with no LC_ALL set. Fails as expected.
- script with export LC_ALL=C.UTF-8
- script with export LC_ALL=C.UTF-9 Fails as expected (sanity check that we don't accidentally match on export LC_ALL=C)
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- lc-all
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 7653 Build 13345: Bitcoin ABC Buildbot (legacy) Build 13344: arc lint + arc unit
Event Timeline
| arcanist/linter/ShellLocaleLinter.php | ||
|---|---|---|
| 1 ↗ | (On Diff #13279) | You should have a very recent phpcs because this rule is 3 months old according to github: It enforces using the new PHP 7 strict_types declaration: https://www.php.net/manual/fr/control-structures.declare.php. Because none of our code nor arcanist code is compliant, an exception can be added to the rule file (arcanist/phpcs.xml). |
| 61 ↗ | (On Diff #13279) | PHP has the array_search() built-in for doing this: if (array_search(trim($matches[0][0]), self::LOCALE_STATEMENTS, true) !== false) { return $this->raiseLintAtPath( self::INVALID_LOCALE, pht('Shell scripts should set the locale to avoid side effects.') ); } |
Comment Actions
Maybe there should be an explicit notice of backport here, as the remaining parts of the PR are Travis related ?
| arcanist/linter/ShellLocaleLinter.php | ||
|---|---|---|
| 61 ↗ | (On Diff #13279) | cool. equality is flipped though ;) |
| arcanist/linter/ShellLocaleLinter.php | ||
|---|---|---|
| 61 ↗ | (On Diff #13279) | Oops... good catch ! |