Remove redundant assignments (dead stores)
ClosedPublic
Actions

Authored by fpelliccioni on Oct 1 2019, 15:41.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGfb43752bb641: Remove redundant assignments (dead stores)
rABCfb43752bb641: Remove redundant assignments (dead stores)

Summary

Remove redundant assignments (dead stores).

Backport of Bitcoin Core PR13767
https://github.com/bitcoin/bitcoin/pull/13767

Test Plan

ninja check
ninja bench-bitcoin
./src/bench/bitcoin-bench

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fpelliccioni created this revision.Oct 1 2019, 15:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2019, 15:41

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7647: Diff 13292.Oct 1 2019, 15:53

test plan.

This revision now requires changes to proceed.Oct 1 2019, 18:35

fpelliccioni edited the test plan for this revision. (Show Details)Oct 3 2019, 11:51

updated test plan.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7677: Diff 13334.Oct 3 2019, 12:57

The test plan doesn't run.

The test plan is meant to describe the step you took to ensure that this patch is good. Clearly, the step described do not match what you have done, as they simply do not work.

This revision now requires changes to proceed.Oct 3 2019, 15:44

In D4189#100853, @deadalnix wrote:

The test plan doesn't run.

The test plan is meant to describe the step you took to ensure that this patch is good. Clearly, the step described do not match what you have done, as they simply do not work.

Yes, you are right, I ran the tests on my machine and they worked correctly, but I made a typo when writing it in the test plan.

fpelliccioni edited the test plan for this revision. (Show Details)Oct 4 2019, 20:22

fpelliccioni edited the test plan for this revision. (Show Details)

test plan fixed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7689: Diff 13354.Oct 4 2019, 20:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Oct 6 2019, 17:56

This revision is now accepted and ready to land.Oct 6 2019, 17:56

Closed by commit rABCfb43752bb641: Remove redundant assignments (dead stores) (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by fpelliccioni). · Explain WhyOct 7 2019, 13:08

This revision was automatically updated to reflect the committed changes.

fpelliccioni added a commit: rABCfb43752bb641: Remove redundant assignments (dead stores).