Make objects in range declarations immutable by default.
Backport of Bitcoin Core PR13249
https://github.com/bitcoin/bitcoin/pull/13249
Make objects in range declarations immutable by default.
Backport of Bitcoin Core PR13249
https://github.com/bitcoin/bitcoin/pull/13249
make check-all
Lint OK |
No Unit Test Coverage |
Buildable 7702 | |
Build 13443: Bitcoin ABC Buildbot (legacy) | |
Build 13442: arc lint + arc unit |
It is a partial application of the PR, I forgot to clarify it, sorry. (summary edited).
I didn't apply the rule for built-in types, because it makes no sense:
for (int x : seq)
is preferred over
for (int const& x : seq).
Have I missed anything else?
for (const int x : seq) is even better. There are still some missing, for instance in qt/bitcoingui.cpp .
Was superseded by D4221.
An error occurred using arc and` git` that I could not solve.
I had help from Fabien.