Separate HaveKey function that checks whether a key is in a keystore
ClosedPublic
Actions

Authored by nakihito on Oct 2 2019, 21:02.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore
rABC613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore

Summary

Functions for later use. See D4202.

Partial (1/4) backport of Core PR12560
https://github.com/bitcoin/bitcoin/pull/12560/commits/dd3c07acce7ab67f32a79393abf6227009bd440d

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12560-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7671
Build 13381: Bitcoin ABC Buildbot (legacy)
Build 13380: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 2 2019, 21:02

Owners added a reviewer: Restricted Owners Package.Oct 2 2019, 21:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2019, 21:02

nakihito planned changes to this revision.Oct 2 2019, 21:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.Oct 2 2019, 21:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7671: Diff 13326.Oct 2 2019, 21:14

nakihito edited the summary of this revision. (Show Details)Oct 3 2019, 18:42

nakihito requested review of this revision.Oct 3 2019, 19:35

nakihito mentioned this in D4171: Merge #12560: [wallet] Upgrade path for non-HD wallets to HD.

nakihito edited the summary of this revision. (Show Details)Oct 3 2019, 20:49

jasonbcox accepted this revision.Oct 3 2019, 20:51

This revision is now accepted and ready to land.Oct 3 2019, 20:51

Closed by commit rABC613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore (authored by Andrew Chow <achow101-github@achow101.com>, committed by nakihito). · Explain WhyOct 3 2019, 20:58

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore.Oct 9 2019, 20:11

Revision Contents
Changeset List

Path

Size

src/

keystore.h

5 lines

keystore.cpp

7 lines

Diff 13326

View Options

src/keystore.h