Paths

Table of Contentst

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
AbandonedPublic
Actions

Authored by fpelliccioni on Oct 7 2019, 14:08.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Summary

Make objects in range declarations immutable by default.

Backport of Bitcoin Core PR13249
https://github.com/bitcoin/bitcoin/pull/13249

Test Plan

make check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature-backport-5c24d3b98

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7701
Build 13441: Bitcoin ABC Buildbot (legacy)
Build 13440: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Oct 7 2019, 14:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2019, 14:08

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Duplicated with D4191.
Reason: arc usage error.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7701: Diff 13376.Oct 7 2019, 14:24

Revision Contents
Changeset List

Path

Size

src/

cuckoocache.h

6 lines

qt/

bitcoingui.cpp

2 lines

sendcoinsdialog.cpp

2 lines

trafficgraphwidget.cpp

4 lines

transactiondesc.cpp

4 lines

transactionrecord.cpp

4 lines

test/

10 lines

8 lines

3 lines

4 lines

4 lines

2 lines

wallet/

rpcdump.cpp

2 lines

wallet.cpp

6 lines

Diff 13376

View Options

src/cuckoocache.h

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/trafficgraphwidget.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/timedata.cpp

View Options

src/validation.cpp

View Options

src/wallet/rpcdump.cpp

View Options

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13376

src/cuckoocache.h

src/qt/bitcoingui.cpp

src/qt/sendcoinsdialog.cpp

src/qt/trafficgraphwidget.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/test/coins_tests.cpp

src/test/dbwrapper_tests.cpp

src/test/skiplist_tests.cpp

src/test/util_tests.cpp

src/timedata.cpp

src/validation.cpp

src/wallet/rpcdump.cpp

src/wallet/wallet.cpp

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
AbandonedPublic
Actions

Revision Contents
Changeset List