Page MenuHomePhabricator
Differential D4224

Rename some seeder options
AbandonedPublic
Actions

Authored by nakihito on Oct 7 2019, 23:28.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

The names for some of the long-form names of seeder options don't make
much sense or are not very descriptive. This change should make it a
little more clear what each option is.

Depends on D4223

Test Plan
make
./bitcoin-seeder -host=seeder.bitframe.org -nameserver=dev.bitframe.org -email=info@bitframe.org -testnet

Output should look something like:

Supporting whitelisted filters: 0x1,0x5,0x11,0x15
Using testnet.
Loading dnsseed.dat...done
Starting 4 DNS threads for  on ` (port 53).......done
Starting seeder...done
Starting 96 crawler threads...2019-10-07T23:26:28Z connect() to [2001:67c:130c:254::46]:8333 failed: Cannot assign requested address (99)
...

Diff Detail

Repository
rABC Bitcoin ABC
Branch
UpdateSeederOptions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7711
Build 13461: Bitcoin ABC Buildbot (legacy)
Build 13460: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 7 2019, 23:28
Owners added a reviewer: Restricted Owners Package.Oct 7 2019, 23:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2019, 23:28
nakihito planned changes to this revision.Oct 7 2019, 23:28
teamcity added a comment.Oct 7 2019, 23:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Oct 7 2019, 23:29
nakihito added a parent revision: D4223: Update Seeder to use ArgsManager.
nakihito edited the test plan for this revision. (Show Details)
nakihito updated this revision to Diff 13396.Oct 7 2019, 23:31

Reverted changes to -proxyipvX.

nakihito planned changes to this revision.Oct 7 2019, 23:31
teamcity added a comment.Oct 7 2019, 23:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 7 2019, 23:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7711: Diff 13395.Oct 7 2019, 23:46
Harbormaster completed remote builds in B7712: Diff 13396.
teamcity added a comment.Oct 7 2019, 23:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Oct 8 2019, 00:08
deadalnix requested changes to this revision.Oct 8 2019, 15:20

Randomly changing parameters without updating the doc or even writing release note is indeed the shortest path toward success.

This revision now requires changes to proceed.Oct 8 2019, 15:20
jasonbcox requested changes to this revision.Oct 9 2019, 00:20

+1 to release notes

src/seeder/main.cpp
357 ↗(On Diff #13396)

s/mbox/email/g on this line would have caught the other use of mbox

nakihito planned changes to this revision.Oct 9 2019, 00:25
nakihito abandoned this revision.Jun 23 2020, 22:21

Revision Contents
Changeset List

PathSize
src/
seeder/
26 lines

Diff 13395

View Options

src/seeder/main.cpp

Loading...