Page MenuHomePhabricator
Differential D4230

Merge #9598: Improve readability by removing redundant casts to same type (on all platforms)
ClosedPublic
Actions

Authored by nakihito on Oct 9 2019, 21:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGdb003f8301e2: Merge #9598: Improve readability by removing redundant casts to same type (on…
rABCdb003f8301e2: Merge #9598: Improve readability by removing redundant casts to same type (on…
Summary

06edc23f7 Improve readability by removing redundant casts to same type (on all platforms) (practicalswift)

Pull request description:

Same binaries check under Linux:

```
$ ../bitcoin-maintainer-tools/build-for-compare.py 874f13821f4193bd037cd37d005ee76b5a849398 82274c02ed2d82537dc55f008a29edb1bc09bbc4 --executables "src/bitcoind,src/bitcoin-cli,src/bitcoin-tx"

$ sha256sum /tmp/compare/*.stripped
1fe1a8827474f7f24475ce3dc851e7ac658d4ed0ae38d11e67f5a810671eaa15  /tmp/compare/bitcoin-cli.82274c02ed2d82537dc55f008a29edb1bc09bbc4.stripped
1fe1a8827474f7f24475ce3dc851e7ac658d4ed0ae38d11e67f5a810671eaa15  /tmp/compare/bitcoin-cli.874f13821f4193bd037cd37d005ee76b5a849398.stripped
342c2ed0e60b60990a58cbf5845b256a4f9e3baff9db074baba5e34a620a60ea  /tmp/compare/bitcoind.82274c02ed2d82537dc55f008a29edb1bc09bbc4.stripped
342c2ed0e60b60990a58cbf5845b256a4f9e3baff9db074baba5e34a620a60ea  /tmp/compare/bitcoind.874f13821f4193bd037cd37d005ee76b5a849398.stripped
e4b2a80b2361d5cefd67a47eeb9298b8b712c26c7779d979348be8b2c7e3ec93  /tmp/compare/bitcoin-tx.82274c02ed2d82537dc55f008a29edb1bc09bbc4.stripped
e4b2a80b2361d5cefd67a47eeb9298b8b712c26c7779d979348be8b2c7e3ec93  /tmp/compare/bitcoin-tx.874f13821f4193bd037cd37d005ee76b5a849398.stripped

$ git diff -W --word-diff /tmp/compare/874f13821f4193bd037cd37d005ee76b5a849398 /tmp/compare/82274c02ed2d82537dc55f008a29edb1bc09bbc4

$
```

Tree-SHA512: 13ca5862fbb03771682b04a7523e581a7fe62e73620fa0e141cf1bc0a3b3f4e2e66bf14b46d1228e2b11b4960153545e7476f3295713a69b5cf5a28a7c2b358d

Backport of Core PR9598
https://github.com/bitcoin/bitcoin/pull/9598/

Test Plan
make check
test_runner.py

Gitian builds on team city.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR9598
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7729
Build 13497: Bitcoin ABC Buildbot (legacy)
Build 13496: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 9 2019, 21:14
Owners added a reviewer: Restricted Owners Package.Oct 9 2019, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2019, 21:14
nakihito planned changes to this revision.Oct 9 2019, 21:14
teamcity added a comment.Oct 9 2019, 21:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 9 2019, 21:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7729: Diff 13478.Oct 9 2019, 21:31
teamcity added a comment.Oct 12 2019, 00:24

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Oct 12 2019, 00:24

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Oct 12 2019, 00:27
teamcity added a comment.Oct 12 2019, 00:29

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Oct 12 2019, 00:29

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Oct 12 2019, 00:40

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Oct 12 2019, 00:42

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

nakihito requested review of this revision.Oct 12 2019, 04:31
deadalnix accepted this revision.Oct 12 2019, 13:07
This revision is now accepted and ready to land.Oct 12 2019, 13:07
Closed by commit rABCdb003f8301e2: Merge #9598: Improve readability by removing redundant casts to same type (on… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyOct 12 2019, 19:46
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCdb003f8301e2: Merge #9598: Improve readability by removing redundant casts to same type (on….
nakihito added a commit: rSTAGINGdb003f8301e2: Merge #9598: Improve readability by removing redundant casts to same type (on….Apr 7 2020, 21:25

Revision Contents
Changeset List

PathSize
src/
6 lines
8 lines

Diff 13478

View Options

src/init.cpp

Loading...
View Options

src/key.cpp

Loading...