Page MenuHomePhabricator
Differential D4239

Merge #13564: [wallet] loadwallet shouldn't create new wallets.
ClosedPublic
Actions

Authored by nakihito on Oct 10 2019, 22:59.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9a4a353f1328: Merge #13564: [wallet] loadwallet shouldn't create new wallets.
rABC9a4a353f1328: Merge #13564: [wallet] loadwallet shouldn't create new wallets.
Summary

ea65182f03 [wallet] loadwallet shouldn't create new wallets. (John Newbery)

Pull request description:

A bug in the initial implementation of loadwallet meant that if the
arguement was a directory that didn't contain a wallet.dat file, a new
wallet would be created in that directory. Fix that so that if a
directory is passed in, it must contain a wallet.dat file.

Bug reported by promag (João Barbosa).

Tree-SHA512: 0a59fa8a33fde51a88544ad288b00e4995284fe16424f643076aaba42b8244fff362145217650ee53d518dfab7efbed4237632c34cdd3dcbbecaa9ecaab5fd7b

Backport of Core PR13564
https://github.com/bitcoin/bitcoin/pull/13564/

Depends on D4236

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13564
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7742
Build 13523: Bitcoin ABC Buildbot (legacy)
Build 13522: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 10 2019, 22:59
Owners added a reviewer: Restricted Owners Package.Oct 10 2019, 22:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2019, 22:59
nakihito planned changes to this revision.Oct 10 2019, 22:59
teamcity added a comment.Oct 10 2019, 22:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 10 2019, 23:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7742: Diff 13496.Oct 10 2019, 23:08
nakihito requested review of this revision.Oct 11 2019, 23:23
deadalnix accepted this revision.Oct 12 2019, 01:29
This revision is now accepted and ready to land.Oct 12 2019, 01:29
Closed by commit rABC9a4a353f1328: Merge #13564: [wallet] loadwallet shouldn't create new wallets. (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyOct 12 2019, 04:41
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC9a4a353f1328: Merge #13564: [wallet] loadwallet shouldn't create new wallets..
nakihito added a commit: rSTAGING9a4a353f1328: Merge #13564: [wallet] loadwallet shouldn't create new wallets..Apr 7 2020, 21:25

Revision Contents
Changeset List

PathSize
src/
wallet/
9 lines
test/
functional/
5 lines

Diff 13496

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...