Page MenuHomePhabricator
Differential D423

Remove mechanism to produce a big block at fork time
ClosedPublic
Actions

Authored by deadalnix on Aug 5 2017, 12:12.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGINGf77fc5c97d4b: Remove mechanism to produce a big block at fork time
rABCf77fc5c97d4b: Remove mechanism to produce a big block at fork time
Summary

The big block rule was removed, so it is all good.

Remove also the configuration constraints related to this.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nobigmine
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 658
Build 658: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 5 2017, 12:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2017, 12:12
deadalnix planned changes to this revision.Aug 5 2017, 12:28

I fubared abc-cmdline.py

deadalnix updated this revision to Diff 1051.Aug 5 2017, 13:31

Fix abc-cmdline.py

sickpig added a subscriber: sickpig.Aug 5 2017, 14:06
sickpig added inline comments.
src/init.cpp
1404 ↗(On Diff #1051)

need to adapt also the comment

deadalnix updated this revision to Diff 1060.Aug 5 2017, 18:08

Remove a unused variable

freetrader edited edge metadata.Aug 5 2017, 21:55

Agree with @sickpig 's review comment which has not been addressed

deadalnix updated this revision to Diff 1070.Aug 6 2017, 13:23

The prunning test uses values that expect a certain block size to be generated. Make sure these value stay correct by specifying a block size to be generated explicitely.

deadalnix updated this revision to Diff 1072.Aug 6 2017, 14:45

Update comment.

Harbormaster completed remote builds in B671: Diff 1072.Aug 6 2017, 14:45
freetrader accepted this revision.Aug 6 2017, 17:56
This revision is now accepted and ready to land.Aug 6 2017, 17:56
Closed by commit rABCf77fc5c97d4b: Remove mechanism to produce a big block at fork time (authored by deadalnix, committed by deadalnix). · Explain WhyAug 6 2017, 18:24
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
43 lines
2 lines
6 lines
src/
18 lines
42 lines
test/
31 lines

Diff 1050

View Options

qa/rpc-tests/abc-cmdline.py

Loading...
View Options

qa/rpc-tests/pruning.py

Loading...
View Options

qa/rpc-tests/smartfees.py

Loading...
View Options

src/init.cpp

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...